ci: restore deploy-test and deploy-prod jobs (truncated in #129) #130

Merged
fastie81 merged 2 commits from fix/deploy-jobs-restore into main 2026-09-05 22:35:59 +12:00
Owner

Bug

Commit e1fcc24 (merged via #129) accidentally truncated the workflow: a bad index operation in the retention step edit deleted everything from the build job onward, dropping the deploy-test and deploy-prod jobs entirely. As a result the main-merge CI run (303) only ran test/lint/build - no deploy to the test node happened.

Fix

Restores the full 5-job single-image pipeline in ci.yml:

  • test, lint-frontend, build (single image, ci-)
  • deploy-test (needs test+lint+build) -> deploys the SAME image to the test node on main and v* tags
  • deploy-prod (needs test+lint+build+deploy-test) -> promotes the SAME image to prod on v* tags, bound to -p honbu-manager-production

The registry-prune step stays correctly inside the build job (does not truncate the tail).

This is the job definition correction - no behavior change beyond restoring the missing deploy steps.

## Bug Commit e1fcc24 (merged via #129) accidentally truncated the workflow: a bad index operation in the retention step edit deleted everything from the build job onward, dropping the deploy-test and deploy-prod jobs entirely. As a result the main-merge CI run (303) only ran test/lint/build - no deploy to the test node happened. ## Fix Restores the full 5-job single-image pipeline in ci.yml: - test, lint-frontend, build (single image, ci-<sha>) - deploy-test (needs test+lint+build) -> deploys the SAME image to the test node on main and v* tags - deploy-prod (needs test+lint+build+deploy-test) -> promotes the SAME image to prod on v* tags, bound to -p honbu-manager-production The registry-prune step stays correctly inside the build job (does not truncate the tail). This is the job definition correction - no behavior change beyond restoring the missing deploy steps.
ci: restore deploy-test and deploy-prod jobs
Some checks failed
CI / test (push) Successful in 2m50s
CI / lint-frontend (push) Successful in 1m14s
CI / build (push) Failing after 2m38s
CI / deploy-test (push) Has been skipped
CI / deploy-prod (push) Has been skipped
3a245d73b9
The retention cleanup change (e1fcc24) accidentally truncated the workflow:
a bad index operation deleted everything from the build job onward, dropping
the deploy-test and deploy-prod jobs entirely - so no deployment happened on
the main merge (run 303 only had test/lint/build).

This restores the full 5-job single-image pipeline (test, lint-frontend,
build, deploy-test, deploy-prod) and keeps the registry-prune step correctly
inside the build job without truncating the tail.
ci: fix retention step - wrong ${{ placeholder broke build
All checks were successful
CI / test (push) Successful in 2m50s
CI / lint-frontend (push) Successful in 1m16s
CI / build (push) Successful in 3m45s
CI / deploy-test (push) Has been skipped
CI / deploy-prod (push) Has been skipped
a7fc75e575
The prune step's bash had a literal ${{D}${{ placeholder (leftover from a
chr-$ workaround) which bash tried to expand as unbound variable D under
set -u, failing the build AFTER the image had already pushed. Replaced with
the correct ${{ env.FORGEJO_TOKEN }} expression (runner substitutes it before
bash). Also deduplicated a doubled -H in the curl lines.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fastie81/honbu-manager!130
No description provided.