fastie81/honbu-manager

Fork 0

feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108) #113

Open

fastie81 wants to merge 8 commits from feature/db-split-phase3-refactoring into main

fastie81 commented

2026-07-16 16:17:29 +12:00

Owner

This Pull Request implements Phase 3 — Repository Refactoring & Cross-DB Gaps (#108).

Proposed Changes

Component 1: DashboardOperations Refactoring

Decoupled DashboardOperations from raw connection wrapper; injected club_repo and system_repo in app/container.py.
Aggregates member count across multiple routed databases under their respective club context in get_system_stats().
Implemented club timezone calculations for upcoming birthdays using get_current_date_in_club_timezone in get_club_dashboard_data().
Wrapped all dashboard API calls and methods in active club routing.

Component 2: System Repository Cross-DB Fixes

Two-Phase Queries:
- get_users_by_club(): Fetches user IDs in club DB, then resolves profiles in central DB.
- get_family_guardians(): Fetches guardian user IDs in club DB, then details in central DB.
- get_available_guardians(): Combines candidate member user IDs, filters current guardians, and resolves details in central DB.
Cascading Deletions:
- delete_user(): Cascades cleanups of user references across all club databases before deleting the record from the Central DB.
- delete_club(): Creates an on-disk JSON backup under the club context first, terminates active backend pg connections, and then drops the database.

Component 3: Application-Level FK Validation

Added check in create_member() and update_member() to ensure user IDs exist in Central DB.
Added check in add_guardian_to_family() to ensure the user ID exists, and automatically registers the user with a 'Member' role assignment for that club in the Central DB.

Component 5: Tests

Created test_dashboard_split.py to assert correct routing context manager stack.
Created test_user_lookups.py to assert two-phase queries return identical structures.
Created test_fk_validation.py to assert ValueErrors on non-existent users.

All unit and E2E controller tests pass successfully.

This Pull Request implements Phase 3 — Repository Refactoring & Cross-DB Gaps (#108). ### Proposed Changes #### Component 1: DashboardOperations Refactoring - Decoupled `DashboardOperations` from raw connection wrapper; injected `club_repo` and `system_repo` in `app/container.py`. - Aggregates member count across multiple routed databases under their respective club context in `get_system_stats()`. - Implemented club timezone calculations for upcoming birthdays using `get_current_date_in_club_timezone` in `get_club_dashboard_data()`. - Wrapped all dashboard API calls and methods in active club routing. #### Component 2: System Repository Cross-DB Fixes - **Two-Phase Queries**: - `get_users_by_club()`: Fetches user IDs in club DB, then resolves profiles in central DB. - `get_family_guardians()`: Fetches guardian user IDs in club DB, then details in central DB. - `get_available_guardians()`: Combines candidate member user IDs, filters current guardians, and resolves details in central DB. - **Cascading Deletions**: - `delete_user()`: Cascades cleanups of user references across all club databases before deleting the record from the Central DB. - `delete_club()`: Creates an on-disk JSON backup under the club context first, terminates active backend pg connections, and then drops the database. #### Component 3: Application-Level FK Validation - Added check in `create_member()` and `update_member()` to ensure user IDs exist in Central DB. - Added check in `add_guardian_to_family()` to ensure the user ID exists, and automatically registers the user with a 'Member' role assignment for that club in the Central DB. #### Component 5: Tests - Created `test_dashboard_split.py` to assert correct routing context manager stack. - Created `test_user_lookups.py` to assert two-phase queries return identical structures. - Created `test_fk_validation.py` to assert ValueErrors on non-existent users. All unit and E2E controller tests pass successfully.

fastie81 added 8 commits

2026-07-16 16:17:31 +12:00

Phase 1: Dynamic Routing Infrastructure (#106 )

CI / test (push) Successful in 5m53s

Details

CI / lint-frontend (push) Successful in 2m8s

Details

0e6b0b009b

Fix issues raised in Phase 1 implementation review

CI / test (push) Successful in 5m25s

Details

CI / lint-frontend (push) Successful in 1m56s

Details

a5e85edc97

Fix deadlock risk in get_engine and fix test mock URL setup

CI / test (push) Successful in 5m51s

Details

CI / lint-frontend (push) Successful in 2m2s

Details

eb22e7a46d

ci: add build-and-push job for Forgejo container registry 1dee4f6e37

- Adds Docker image build and push to registry on successful CI
- Uses forgejo.repository_owner and forgejo.token for auth
- Tags: branch refs, semver versions, and latest on main branch
- Depends on test job to ensure only validated images are pushed

chore: restore original docker-compose.yml, add registry override 541185102b

- Restores original docker-compose.yml with clean build configuration
- Adds docker-compose.registry.yml for pulling pre-built images from Forgejo registry
- Use: docker-compose -f docker-compose.yml -f docker-compose.registry.yml up -d

feat: add docker-compose.registry.yml for Forgejo registry deployment 0997d36cf1

This override file configures docker-compose to pull images from the
Forgejo container registry instead of building locally.

Usage on server:
  docker login forgejo.scrat.co.nz
  docker-compose -f docker-compose.yml -f docker-compose.registry.yml up -d

feat(db-split): separate central and club migrations with dynamic tenant DB provisioning and security guards

ci.yml / feat(db-split): separate central and club migrations with dynamic tenant DB provisioning and security guards (push) Failing after 0s

Details

ci.yml / feat(db-split): separate central and club migrations with dynamic tenant DB provisioning and security guards (pull_request) Failing after 0s

Details

790548d6e3

feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108 )

ci.yml / feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108) (push) Failing after 0s

Details

ci.yml / feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108) (pull_request) Failing after 0s

Details

9a27db2558

fastie81 referenced this pull request

2026-07-16 16:17:33 +12:00

Phase 3 — Repository Refactoring & Cross-DB Gaps #108

ci.yml / feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108) (push) Failing after 0s

Details

ci.yml / feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108) (pull_request) Failing after 0s

Details

CI / test (pull_request)

Required

CI / lint-frontend (pull_request)

Required

This pull request has changes conflicting with the target branch.

.forgejo/workflows/ci.yml
docker-compose.test.yml
docker-compose.yml

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108)' (#113) from feature/db-split-phase3-refactoring into main

Merge commit body

Reviewed-on: https://forgejo.scrat.co.nz/fastie81/honbu-manager/pulls/113

Merge pull request 'feat(db-split): Phase 3 — Repository Refactoring & Cross-DB Gaps (#108)' (#113) from feature/db-split-phase3-refactoring into main

Reviewed-on: https://forgejo.scrat.co.nz/fastie81/honbu-manager/pulls/113