fix: photo upload/delete 500 for non-Member roles (UnboundLocalError) #143

Merged

fastie81 merged 2 commits from fix/photo-upload-unbound into main

2026-10-21 18:36:29 +13:00

fastie81 commented

2026-10-21 17:49:34 +13:00

Owner

Problem

Prod logs (15 Oct) show POST /api/members/<id>/photo returning 500 with UnboundLocalError: cannot access local variable 'member_ops'.

Cause

In MemberPhoto.post and .delete, from app.container import member_ops sits inside if role == 'Member':. That makes member_ops function-local, so any non-Member role hits an unbound variable at save_member_photo / delete_member_photo. The module already imports member_ops at line 10.

Fix

Remove the two inner imports (-2 lines). Same singleton object, so no behaviour change for Member role.

Tests

New tests/unit/test_member_photo_unbound.py: upload + delete as Club Admin -> 200.
Mutation: both fail with 500 on old code, pass with fix.
Unit suite: 198 pass, 2 fail (test_club_switch_mock switch_club_success_admin/member) - pre-existing on main, unrelated.

## Problem Prod logs (15 Oct) show `POST /api/members/<id>/photo` returning 500 with `UnboundLocalError: cannot access local variable 'member_ops'`. ## Cause In `MemberPhoto.post` and `.delete`, `from app.container import member_ops` sits inside `if role == 'Member':`. That makes `member_ops` function-local, so any non-Member role hits an unbound variable at `save_member_photo` / `delete_member_photo`. The module already imports `member_ops` at line 10. ## Fix Remove the two inner imports (-2 lines). Same singleton object, so no behaviour change for Member role. ## Tests - New `tests/unit/test_member_photo_unbound.py`: upload + delete as Club Admin -> 200. - Mutation: both fail with 500 on old code, pass with fix. - Unit suite: 198 pass, 2 fail (`test_club_switch_mock` switch_club_success_admin/member) - pre-existing on main, unrelated.

fastie81 added 1 commit

2026-10-21 17:49:36 +13:00

fix: remove shadowing local import of member_ops in photo handlers

CI / test (push) Failing after 1m27s

Details

CI / lint-frontend (push) Successful in 1m7s

Details

CI / build (push) Has been skipped

Details

CI / deploy (push) Has been skipped

Details

888ec8518e